[GeoMechanicsApplication] A 3D elastic constitutive law is lacking in GeoMechanicsApplication #12816

markelov208 · 2024-11-01T15:23:57Z

📝 Description
A brief description of the PR.

renamed GeoLinearElasticPlaneStress2DLaw to GeoIncrementalLinearElasticLaw
added Elastic3D() law like PlaneStrain()
registered GeoLinearElastic3DLaw
added unit tests for GeoLinearElastic3DLaw
replaced LinearElastic3DLaw with GeoLinearElastic3DLaw for integration tests

AlejandroCornejo · 2024-11-02T14:40:55Z

it is none of my bussiness ;) but would it be possible to generalize the existing CLs from the SMApp to satisfy your needs?

WPK4FEM

Hi Gennady,
Thank you for this effective continuation of the incremental elastic material setup. The important remark in my small comments is probably the one about the incremental nature.
Regards, Wijtze Pieter

WPK4FEM · 2024-11-04T07:40:39Z

applications/GeoMechanicsApplication/custom_constitutive/incremental_linear_elastic_law.cpp

 }

-bool& GeoLinearElasticPlaneStrain2DLaw::GetValue(const Variable<bool>& rThisVariable, bool& rValue)
+bool& GeoIncrementalLinearElasticLaw::GetValue(const Variable<bool>& rThisVariable, bool& rValue)


Perhaps we should find out what Stenberg shear stabilization is and whether it is applicable for elasticity. We are moving this around, but we are not really using it.

Looked at Stenberg stabilization. Only seems applicable for thick shell formulation used in Structural Mechanics Applications. I consider it to be part of another PR to limit its use to meaningful use in GeoMechanics.

WPK4FEM · 2024-11-04T08:20:04Z

applications/GeoMechanicsApplication/custom_constitutive/incremental_linear_elastic_law.cpp

 {
    // This Constitutive Law has been checked with Stenberg Stabilization
    if (rThisVariable == STENBERG_SHEAR_STABILIZATION_SUITABLE) rValue = true;
    return rValue;
 }

-void GeoLinearElasticPlaneStrain2DLaw::GetLawFeatures(Features& rFeatures)
+void GeoIncrementalLinearElasticLaw::GetLawFeatures(Features& rFeatures)


The implementation reads like SetFeatureOptions.

Indeed ;) It is used across Kratos.

WPK4FEM · 2024-11-04T08:22:12Z

applications/GeoMechanicsApplication/custom_constitutive/linear_elastic_2D_beam_law.h

@@ -53,7 +53,7 @@ class KRATOS_API(GEO_MECHANICS_APPLICATION) LinearElastic2DBeamLaw : public GeoL
    using CLBaseType = ConstitutiveLaw;

    /// The base class ElasticIsotropicK03DLaw type definition


Rotting comment, was already wrong before the current change.

WPK4FEM · 2024-11-04T08:23:34Z

applications/GeoMechanicsApplication/custom_constitutive/linear_elastic_2D_interface_law.h

@@ -53,7 +53,7 @@ class KRATOS_API(GEO_MECHANICS_APPLICATION) LinearElastic2DInterfaceLaw : public
    using CLBaseType = ConstitutiveLaw;

    /// The base class ElasticIsotropicK03DLaw type definition


Same wrong comment.

WPK4FEM · 2024-11-04T08:33:50Z

...s/GeoMechanicsApplication/tests/cpp_tests/custom_constitutive/test_linear_elastic_3D_law.cpp

+    KRATOS_EXPECT_VECTOR_RELATIVE_NEAR(expected_stress, stress, 1e-3);
+}
+
+KRATOS_TEST_CASE_IN_SUITE(GeoLinearElastic3DLawReturnsExpectedStress_WhenOnlyDiagonalEntriesAreConsidered,


Yes, really good to test this as it is a necessity for doing the K0 things in 3D.

All credits to Richard. I've just applied his tests.

WPK4FEM · 2024-11-04T08:36:14Z

...s/GeoMechanicsApplication/tests/cpp_tests/custom_constitutive/test_linear_elastic_3D_law.cpp

@@ -0,0 +1,175 @@
+// KRATOS___


The incremental nature of the law is not tested yet. That would require two steps and change of the Young's modulus in between, to distinguish between an incremental and a total formulation.

It is tested for the GeoIncrementalLinearElasticLaw with a 2D ConstitutiveDimension though, since the incremental nature is not really dimension-specific, that could be enough, let's have a discussion on this.

I should have read more carefully, Richard has shown me that the testing is there also for 3D.

rfaasse

Very neat and clear PR, thank you for your effort and delivering a PR this quickly!

The comments I have are mainly about naming and docstrings, so easy to fix (but still hard to find the correct names). Other than that I think it'd be a good idea to discuss the testing of the incremental nature (i.e. are the unit tests for the law with 2D behavior enough or do we need to do a similar thing for 3D).

rfaasse · 2024-11-04T09:29:21Z

applications/GeoMechanicsApplication/geo_mechanics_application.cpp

@@ -351,6 +351,7 @@ void KratosGeoMechanicsApplication::Register()
    KRATOS_REGISTER_CONSTITUTIVE_LAW("LinearElasticPlaneStrainK02DLaw", mLinearPlaneStrainK0Law)
    KRATOS_REGISTER_CONSTITUTIVE_LAW("LinearElasticK03DLaw", mElasticIsotropicK03DLaw)
    KRATOS_REGISTER_CONSTITUTIVE_LAW("GeoLinearElasticPlaneStrain2DLaw", mLinearElasticPlaneStrain2DLaw)
+    KRATOS_REGISTER_CONSTITUTIVE_LAW("GeoLinearElastic3DLaw", mLinearElastic3DLaw)


I think we should have the 'incremental' specifier in the registered name (maybe GeoIncrementalLinearElastic3DLaw?), but it's good to also have @WPK4FEM's opinion on this)

I agree to have "Incremental" in the registered name.

I share Richards point of view.

Added Incremental

rfaasse · 2024-11-04T09:32:23Z

applications/GeoMechanicsApplication/custom_constitutive/elastic_3D.h

+namespace Kratos
+{
+
+class KRATOS_API(GEO_MECHANICS_APPLICATION) Elastic3D : public ConstitutiveLawDimension


I'm doubting a bit about the name of the class, the plane strain counterpart is just called PlaneStrain, but I'm not sure if ThreeDimensional would be descriptive enough.

I'm in favor of renaming this class to ThreeDimensional. Needless to say that we then also need to rename this header file as well as the corresponding implementation file.

For me it is.

What do @rfaasse and @WPK4FEM think about ElasticIsotropic3D and to change ConstitutiveLawDimension to ConstitutiveLawType? For example, there is GeoLinearElasticPlaneStress2DLaw which fits this structure perfectly using PlaneStress like PlaneStrain. Another candidate is ElasticIsotropicK03DLaw. Thank you.

Changed to ThreeDimensional. However, looking to a discussion on my suggestion. ;)

rfaasse · 2024-11-04T09:37:01Z

applications/GeoMechanicsApplication/custom_constitutive/incremental_linear_elastic_law.h

+ * @class GeoIncrementalLinearElasticLaw
 * @ingroup GeoMechanicsApplication
- * @brief This class defines a small deformation linear elastic constitutive model for plane strain cases
+ * @brief This class defines a small deformation linear elastic constitutive model for plane strain and 3D cases
 * @author Vahid Galavi


I think this could be re-written a bit more (as you already started doing so): I'd propose something like:
This class defines an incremental linear elastic constitutive model for plane strain and 3D cases.

I don't think that 'small deformation' is really accurate (or has anything to do with the linear elastic model), but please correct me if I'm wrong (tagging you @WPK4FEM, to hear your opinion on this as well)

To stress the incremental nature of the implementation, we could replace "small deformation" with "incremental". The formulation can be used both for small deformation and large deformation.

replaced small deformation with incremental

WPK4FEM

Trying to revert my not so to the point questions and agreeing with Richard.

WPK4FEM · 2024-11-05T14:45:14Z

applications/GeoMechanicsApplication/custom_constitutive/incremental_linear_elastic_law.cpp

 }

-bool& GeoLinearElasticPlaneStrain2DLaw::GetValue(const Variable<bool>& rThisVariable, bool& rValue)
+bool& GeoIncrementalLinearElasticLaw::GetValue(const Variable<bool>& rThisVariable, bool& rValue)


Looked at Stenberg stabilization. Only seems applicable for thick shell formulation used in Structural Mechanics Applications. I consider it to be part of another PR to limit its use to meaningful use in GeoMechanics.

WPK4FEM · 2024-11-05T14:50:22Z

applications/GeoMechanicsApplication/custom_constitutive/incremental_linear_elastic_law.h

+ * @class GeoIncrementalLinearElasticLaw
 * @ingroup GeoMechanicsApplication
- * @brief This class defines a small deformation linear elastic constitutive model for plane strain cases
+ * @brief This class defines a small deformation linear elastic constitutive model for plane strain and 3D cases
 * @author Vahid Galavi


To stress the incremental nature of the implementation, we could replace "small deformation" with "incremental". The formulation can be used both for small deformation and large deformation.

WPK4FEM · 2024-11-05T14:51:32Z

applications/GeoMechanicsApplication/geo_mechanics_application.cpp

@@ -351,6 +351,7 @@ void KratosGeoMechanicsApplication::Register()
    KRATOS_REGISTER_CONSTITUTIVE_LAW("LinearElasticPlaneStrainK02DLaw", mLinearPlaneStrainK0Law)
    KRATOS_REGISTER_CONSTITUTIVE_LAW("LinearElasticK03DLaw", mElasticIsotropicK03DLaw)
    KRATOS_REGISTER_CONSTITUTIVE_LAW("GeoLinearElasticPlaneStrain2DLaw", mLinearElasticPlaneStrain2DLaw)
+    KRATOS_REGISTER_CONSTITUTIVE_LAW("GeoLinearElastic3DLaw", mLinearElastic3DLaw)


I share Richards point of view.

avdg81

This is very clean and clear extension of the incremental linear elastic law. All of my comments are minor in nature. The one thing I'd like to add is that there are three README.md files that still refer to the previous constitutive law name (i.e. LinearElastic3DLaw):

tests/compressibility_tests/README.md
tests/hexa_8n_normal_load/README.md
tests/lysmer_boundary_column3D/README.md

I guess those need to updated, too.

avdg81 · 2024-11-05T10:41:35Z

applications/GeoMechanicsApplication/custom_constitutive/elastic_3D.h

+namespace Kratos
+{
+
+class KRATOS_API(GEO_MECHANICS_APPLICATION) Elastic3D : public ConstitutiveLawDimension


I'm in favor of renaming this class to ThreeDimensional. Needless to say that we then also need to rename this header file as well as the corresponding implementation file.

applications/GeoMechanicsApplication/custom_constitutive/elastic_3D.h

applications/GeoMechanicsApplication/custom_constitutive/linear_elastic_2D_beam_law.h

applications/GeoMechanicsApplication/custom_constitutive/linear_elastic_2D_interface_law.h

avdg81 · 2024-11-05T11:02:22Z

applications/GeoMechanicsApplication/geo_mechanics_application.cpp

@@ -351,6 +351,7 @@ void KratosGeoMechanicsApplication::Register()
    KRATOS_REGISTER_CONSTITUTIVE_LAW("LinearElasticPlaneStrainK02DLaw", mLinearPlaneStrainK0Law)
    KRATOS_REGISTER_CONSTITUTIVE_LAW("LinearElasticK03DLaw", mElasticIsotropicK03DLaw)
    KRATOS_REGISTER_CONSTITUTIVE_LAW("GeoLinearElasticPlaneStrain2DLaw", mLinearElasticPlaneStrain2DLaw)
+    KRATOS_REGISTER_CONSTITUTIVE_LAW("GeoLinearElastic3DLaw", mLinearElastic3DLaw)


I agree to have "Incremental" in the registered name.

...s/GeoMechanicsApplication/tests/cpp_tests/custom_constitutive/test_linear_elastic_3D_law.cpp

markelov208 · 2024-11-05T20:07:25Z

This is very clean and clear extension of the incremental linear elastic law. All of my comments are minor in nature. The one thing I'd like to add is that there are three README.md files that still refer to the previous constitutive law name (i.e. LinearElastic3DLaw):

tests/compressibility_tests/README.md

tests/hexa_8n_normal_load/README.md

tests/lysmer_boundary_column3D/README.md

I guess those need to updated, too.

These READMEs are corrected.

markelov208

Hi guys, many thanks for your suggestions.

markelov208 · 2024-11-05T19:51:40Z

applications/GeoMechanicsApplication/custom_constitutive/incremental_linear_elastic_law.cpp

 {
    // This Constitutive Law has been checked with Stenberg Stabilization
    if (rThisVariable == STENBERG_SHEAR_STABILIZATION_SUITABLE) rValue = true;
    return rValue;
 }

-void GeoLinearElasticPlaneStrain2DLaw::GetLawFeatures(Features& rFeatures)
+void GeoIncrementalLinearElasticLaw::GetLawFeatures(Features& rFeatures)


Indeed ;) It is used across Kratos.

markelov208 · 2024-11-05T19:53:44Z

applications/GeoMechanicsApplication/custom_constitutive/linear_elastic_2D_beam_law.h

@@ -53,7 +53,7 @@ class KRATOS_API(GEO_MECHANICS_APPLICATION) LinearElastic2DBeamLaw : public GeoL
    using CLBaseType = ConstitutiveLaw;

    /// The base class ElasticIsotropicK03DLaw type definition


markelov208 · 2024-11-05T19:54:10Z

applications/GeoMechanicsApplication/custom_constitutive/linear_elastic_2D_interface_law.h

@@ -53,7 +53,7 @@ class KRATOS_API(GEO_MECHANICS_APPLICATION) LinearElastic2DInterfaceLaw : public
    using CLBaseType = ConstitutiveLaw;

    /// The base class ElasticIsotropicK03DLaw type definition


markelov208 · 2024-11-05T19:54:45Z

...s/GeoMechanicsApplication/tests/cpp_tests/custom_constitutive/test_linear_elastic_3D_law.cpp

+    KRATOS_EXPECT_VECTOR_RELATIVE_NEAR(expected_stress, stress, 1e-3);
+}
+
+KRATOS_TEST_CASE_IN_SUITE(GeoLinearElastic3DLawReturnsExpectedStress_WhenOnlyDiagonalEntriesAreConsidered,


All credits to Richard. I've just applied his tests.

markelov208 · 2024-11-05T19:55:17Z

applications/GeoMechanicsApplication/geo_mechanics_application.cpp

@@ -351,6 +351,7 @@ void KratosGeoMechanicsApplication::Register()
    KRATOS_REGISTER_CONSTITUTIVE_LAW("LinearElasticPlaneStrainK02DLaw", mLinearPlaneStrainK0Law)
    KRATOS_REGISTER_CONSTITUTIVE_LAW("LinearElasticK03DLaw", mElasticIsotropicK03DLaw)
    KRATOS_REGISTER_CONSTITUTIVE_LAW("GeoLinearElasticPlaneStrain2DLaw", mLinearElasticPlaneStrain2DLaw)
+    KRATOS_REGISTER_CONSTITUTIVE_LAW("GeoLinearElastic3DLaw", mLinearElastic3DLaw)


Added Incremental

applications/GeoMechanicsApplication/custom_constitutive/linear_elastic_2D_beam_law.h

applications/GeoMechanicsApplication/custom_constitutive/linear_elastic_2D_interface_law.h

...s/GeoMechanicsApplication/tests/cpp_tests/custom_constitutive/test_linear_elastic_3D_law.cpp

rfaasse

Thank you for processing the review comments, I only have two very minor nitpicky comments left, but to me this PR is as good as ready!

rfaasse · 2024-11-07T08:09:40Z

...icsApplication/tests/cpp_tests/custom_constitutive/test_inremental_linear_elastic_3D_law.cpp

Minor typo in the name (inremental -> incremental)

rfaasse · 2024-11-08T08:12:26Z

applications/GeoMechanicsApplication/custom_constitutive/incremental_linear_elastic_law.h

 * @ingroup GeoMechanicsApplication
- * @brief This class defines a small deformation linear elastic constitutive model for plane strain cases
+ * @brief This class defines a incremental linear elastic constitutive model for plane strain and 3D cases


Very minor (nitpicking at this point)

Suggested change

* @brief This class defines a incremental linear elastic constitutive model for plane strain and 3D cases

* @brief This class defines an incremental linear elastic constitutive model for plane strain and 3D cases

avdg81

I believe we're almost there. I just have two very minor suggestions left. Thank you so much for the work done so far. Much appreciated.

applications/GeoMechanicsApplication/custom_constitutive/linear_elastic_2D_beam_law.h

applications/GeoMechanicsApplication/custom_constitutive/linear_elastic_2D_interface_law.h

avdg81

Let's merge this PR :-)

rfaasse · 2024-11-08T10:47:08Z

it is none of my bussiness ;) but would it be possible to generalize the existing CLs from the SMApp to satisfy your needs?

Hi @AlejandroCornejo, thanks for reaching out! In principle a 3D linear elastic law is indeed not something that's specific for geomechanics and we could re-use from structural. Right now there are still two reasons why we still have a different version in geo:

The formulation we added is incremental
We need the possibility to only consider diagonal terms in our constitutive matrix and disregard the shear terms (and control from outside of the constitutive law when this happens).

However, since you're of course more familiar with the SMApp, we might have missed possibilities to re-use your CLs, so please let us know if you see possibilities for collaboration here!

renamed GeoLinearElasticPlaneStrain2DLaw to GeoIncrementalLinerLaw

2ce1e36

markelov208 self-assigned this Nov 1, 2024

markelov208 added 3 commits November 1, 2024 19:49

added elastic_3D law and unit tests

c6e43b4

clang-format

27e4090

used GeoLinearElastic3DLaw

e927d15

markelov208 requested review from rfaasse, avdg81 and WPK4FEM November 1, 2024 23:02

markelov208 linked an issue Nov 1, 2024 that may be closed by this pull request

[GeoMechanicsApplication] A 3D elastic constitutive law is lacking in GeoMechanicsApplication #12814

Closed

markelov208 added 2 commits November 4, 2024 08:53

Merge branch 'master' into geo/12814_3D_elastic_constitutive_law

82fe15f

Merge branch 'master' into geo/12814_3D_elastic_constitutive_law

9889c47

WPK4FEM reviewed Nov 4, 2024

View reviewed changes

rfaasse reviewed Nov 4, 2024

View reviewed changes

fixed comments

8ce1180

WPK4FEM reviewed Nov 5, 2024

View reviewed changes

used GeoIncrementalLinearElastic3DLaw

b683398

avdg81 reviewed Nov 5, 2024

View reviewed changes

markelov208 added 2 commits November 5, 2024 19:59

response to reviews

95893d9

Merge branch 'master' into geo/12814_3D_elastic_constitutive_law

b081e1e

markelov208 commented Nov 5, 2024

View reviewed changes

markelov208 requested review from avdg81, WPK4FEM and rfaasse November 5, 2024 20:08

formatted

96954f7

rfaasse reviewed Nov 8, 2024

View reviewed changes

markelov208 added 2 commits November 8, 2024 09:28

Merge branch 'master' into geo/12814_3D_elastic_constitutive_law

4077a4a

fixed an

7477196

avdg81 reviewed Nov 8, 2024

View reviewed changes

applications/GeoMechanicsApplication/custom_constitutive/linear_elastic_2D_beam_law.h Show resolved Hide resolved

applications/GeoMechanicsApplication/custom_constitutive/linear_elastic_2D_interface_law.h Show resolved Hide resolved

removed two lines with ///

2d19354

avdg81 approved these changes Nov 8, 2024

View reviewed changes

markelov208 enabled auto-merge (squash) November 8, 2024 09:30

markelov208 merged commit 8cdabbc into master Nov 8, 2024
11 checks passed

markelov208 deleted the geo/12814_3D_elastic_constitutive_law branch November 8, 2024 10:46

		@@ -53,7 +53,7 @@ class KRATOS_API(GEO_MECHANICS_APPLICATION) LinearElastic2DBeamLaw : public GeoL
		using CLBaseType = ConstitutiveLaw;

		/// The base class ElasticIsotropicK03DLaw type definition

	* @brief This class defines a incremental linear elastic constitutive model for plane strain and 3D cases
	* @brief This class defines an incremental linear elastic constitutive model for plane strain and 3D cases

[GeoMechanicsApplication] A 3D elastic constitutive law is lacking in GeoMechanicsApplication #12816

[GeoMechanicsApplication] A 3D elastic constitutive law is lacking in GeoMechanicsApplication #12816

Conversation

markelov208 commented Nov 1, 2024 • edited Loading

AlejandroCornejo commented Nov 2, 2024 • edited Loading

WPK4FEM left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rfaasse Nov 4, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rfaasse left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

WPK4FEM left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

avdg81 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

markelov208 commented Nov 5, 2024

markelov208 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rfaasse left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

avdg81 left a comment

Choose a reason for hiding this comment

avdg81 left a comment

Choose a reason for hiding this comment

rfaasse commented Nov 8, 2024

markelov208 commented Nov 1, 2024 •

edited

Loading

AlejandroCornejo commented Nov 2, 2024 •

edited

Loading

rfaasse Nov 4, 2024 •

edited

Loading